Update Translation2dSubject and Translation3dSubject to use distance#156
Merged
Conversation
kcooney
force-pushed
the
kcooney/translation_subject
branch
from
1f7d548 to
03ab88e
Compare
kcooney
changed the title
cuttestkittensrule
approved these changes
Jun 10, 2026
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. It looks like there are two places where you forgot to remove the old assertions, which should probably be removed.
cuttestkittensrule
added a commit
that referenced
this pull request
Jun 10, 2026
…0 in the tolerence Should just use the helper method once #156 gets merged into main fully
cuttestkittensrule
pushed a commit
that referenced
this pull request
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.